ESQL: No, line noise isn't a valid ip #127527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote an `&&` when I meant and `||` in elastic#126338 and that caused some impressive looking line noise to parse as valid ipv4 addresses. Randomized tests caught it eventually.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @nik9000, I've created a changelog YAML for you. |
nik9000
added
auto-backport
elasticsearchmachine
added
the
Team:Analytics
dnhatn
approved these changes
Apr 29, 2025
|
Thanks @dnhatn ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 29, 2025
I wrote an `&&` when I meant and `||` in elastic#126338 and that caused some impressive looking line noise to parse as valid ipv4 addresses. Randomized tests caught it eventually.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 29, 2025
I wrote an `&&` when I meant and `||` in elastic#126338 and that caused some impressive looking line noise to parse as valid ipv4 addresses. Randomized tests caught it eventually.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote an
&&when I meant and||in #126338 and that caused some impressive looking line noise to parse as valid ipv4 addresses. Randomized tests caught it eventually.